Skip to content

fix(compiler-core): do not increase newlines in InEntity state #13362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(compiler-core): do not increase newlines in InEntity state #13362

wants to merge 3 commits into from
+6 −1

Conversation

KazariEX
Copy link
Member

@KazariEX KazariEX commented May 21, 2025 •
edited by coderabbitai bot
Loading

fix #13361

Summary by CodeRabbit

  • Tests

    • Added a test to ensure correct line number tracking for elements with multiline attribute values ending with an ampersand.

  • Bug Fixes

    • Improved handling of newline tracking during parsing to ensure accurate location metadata for multiline attribute values.

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented May 21, 2025 •
edited
Loading

"""

Walkthrough

A test was added to verify correct line number tracking for elements with multiline attribute values ending with an ampersand. The tokenizer logic was updated so that newline positions are not recorded when inside an entity decoding sequence, improving the accuracy of location metadata during parsing.

Changes

File(s) Change Summary
packages/compiler-core/tests/parse.spec.ts Added a test for multiline attribute values ending with an ampersand, checking accurate line tracking.
packages/compiler-core/src/tokenizer.ts Modified newline tracking logic to skip recording newlines when in the InEntity state.

Assessment against linked issues

Objective Addressed Explanation
Ensure correct location metadata for multiline attribute values (especially with &) (#13361) ✅

Poem

A rabbit with code in its paws,
Hopped through newlines, found the cause—
Ampersands at the end,
Now no longer offend,
For line numbers are fixed—applause!
🐇✨
"""

Note

⚡️ AI Code Reviews for VS Code, Cursor, Windsurf

CodeRabbit now has a plugin for VS Code, Cursor and Windsurf. This brings AI code reviews directly in the code editor. Each commit is reviewed immediately, finding bugs before the PR is raised. Seamless context handoff to your AI code agent ensures that you can easily incorporate review feedback.
Learn more here.

Note

⚡️ Faster reviews with caching

CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 30th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.
Enjoy the performance boost—your workflow just got faster.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between cbd0a0d and a47a8b0.

📒 Files selected for processing (1)
  • packages/compiler-core/__tests__/parse.spec.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/compiler-core/tests/parse.spec.ts
⏰ Context from checks skipped due to timeout of 90000ms (4)
  • GitHub Check: Redirect rules
  • GitHub Check: Header rules
  • GitHub Check: Pages changed
  • GitHub Check: test / unit-test-windows
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 38.3 kB 34.6 kB
vue.global.prod.js 159 kB (+17 B) 58.5 kB (+5 B) 52.1 kB (+87 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.6 kB 18.2 kB 16.7 kB
createApp 54.5 kB 21.2 kB 19.4 kB
createSSRApp 58.8 kB 23 kB 20.9 kB
defineCustomElement 59.5 kB 22.8 kB 20.8 kB
overall 68.6 kB 26.4 kB 24.1 kB

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented May 21, 2025 •
edited
Loading

Open in StackBlitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@13362

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@13362

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@13362

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@13362

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@13362

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@13362

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@13362

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@13362

@vue/shared

npm i https://pkg.pr.new/@vue/shared@13362

vue

npm i https://pkg.pr.new/vue@13362

@vue/compat

npm i https://pkg.pr.new/@vue/compat@13362

commit: a47a8b0

@KazariEX KazariEX changed the title fix(compiler-core): correct loc when a line in attribute value ends with & fix(compiler-core): do not increase newlines in InEntity state May 21, 2025
@KazariEX KazariEX marked this pull request as ready for review May 21, 2025 09:10
@KazariEX KazariEX added scope: compiler 🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. labels May 21, 2025
@KazariEX
Copy link
Member Author

/ecosystem-ci run

@vue-bot
Copy link
Contributor

vue-bot commented May 21, 2025

📝 Ran ecosystem CI: Open

suite result latest scheduled
primevue ✅ success ✅ success
nuxt ✅ success ✅ success
language-tools ✅ success ✅ success
vue-i18n ✅ success ✅ success
router ✅ success ✅ success
vue-simple-compiler ✅ success ✅ success
test-utils ✅ success ✅ success
vitepress ✅ success ✅ success
vuetify ✅ success ✅ success
vue-macros ✅ success ✅ success
quasar ✅ success ✅ success
pinia ✅ success ✅ success
radix-vue ✅ success ✅ success
vant ✅ success ✅ success
vite-plugin-vue ✅ success ✅ success
vueuse ✅ success ✅ success

@edison1105 edison1105 added the ready to merge The PR is ready to be merged. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edison1105 edison1105 edison1105 left review comments

Assignees
No one assigned
Labels
🍰 p2-nice-to-have Priority 2: this is not breaking anything but nice to have it addressed. ready to merge The PR is ready to be merged. scope: compiler
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: @vue/compiler-sfc template loc wrong
3 participants
@KazariEX @vue-bot @edison1105